Repository navigation
Conversation
Add a separate workflow for the manual hooks
There was a problem hiding this comment.
🟡 Changes recommended
The manual workflow duplicates the Run pre-commit check name on pull requests, which can create ambiguous results and block merging if branch protection requires that check.
1 open issue
What changed in this PR
This PR advances the migration from pre-commit to prek described in #14093 and separates manual-stage hooks into their own CI workflow.
Changes:
- Replace explicit Python setup, installation, and caching with
j178/prek-action. - Run manual-stage hooks in a separate pull-request workflow.
- Update checkout and adjust cancellation behavior in both workflows.
| File | Description |
|---|---|
.github/workflows/pre-commit.yml |
Switch normal hooks to prek-action and remove manual-stage execution. |
.github/workflows/pre-commit-manual.yml |
Add a dedicated workflow for running manual-stage hooks with prek. |
Review effort: Balanced
45a46f9 to
4ddc813
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14549 +/- ##
============================================
+ Coverage 20.76% 20.78% +0.01%
- Complexity 21905 21931 +26
============================================
Files 6496 6496
Lines 591605 591657 +52
Branches 72583 72592 +9
============================================
+ Hits 122854 122966 +112
+ Misses 455414 455346 -68
- Partials 13337 13345 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@jbampton , the prek standard job fails (also after retried) can you have a look? |
There was a problem hiding this comment.
🟡 Changes recommended
The manual workflow can populate the shared cache with incomplete hook environments, forcing subsequent standard runs to reinstall dependencies without being able to update the cache on exact hits.
1 open issue
Review effort: Balanced
There was a problem hiding this comment.
🔵 Needs a closer look
Human assessment is needed because an unpublished workflow-concurrency finding indicates obsolete hook runs may compete with current checks for runner capacity.
No open issues 🎉
1 resolved since last review
Review effort: Balanced
| persist-credentials: false | ||
| - uses: j178/prek-action@44924fe9ef4a6f88253c4b6b1bf11c689d3ce53d # v3.1.0 | ||
| with: | ||
| extra-args: --all-files --show-diff-on-failure --color=always |
Add a separate workflow for the manual hooks
Description
This PR refs #14093
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?